-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace atomicwrites with os.replace #10115
Conversation
e3a0670
to
842e2dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
changelog/10114.improvement.rst
Outdated
@@ -0,0 +1 @@ | |||
Replace `atomicwrites` dependency on windows with `os.replace`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace `atomicwrites` dependency on windows with `os.replace`. | |
Replace `atomicwrites <https://github.com/untitaker/python-atomicwrites>`__ dependency on windows with `os.replace`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also perhaps we can consider this trivial
and backport it to 7.1.x?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep will rename the file and amend when I'm at a computer
842e2dd
to
4cd0322
Compare
resolves #10114
diff is best viewed with ?w=1